[DO NOT MERGE] Post Election Changes #1731
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huwd
force-pushed
the
groupActionsByResults
branch
from
2ee0db5
to
3bd59da
Compare
huwd
changed the title
huwd
force-pushed
the
groupActionsByResults
branch
from
3bd59da
to
88195a4
Compare
huwd
force-pushed
the
groupActionsByResults
branch
from
0e1755f
to
564275d
Compare
huwd
force-pushed
the
groupActionsByResults
branch
from
bdf382b
to
fbdd8ef
Compare
koetsier
reviewed
Nov 12, 2019
koetsier
reviewed
Nov 12, 2019
koetsier
reviewed
Nov 12, 2019
koetsier
reviewed
Nov 12, 2019
koetsier
reviewed
Nov 12, 2019
koetsier
reviewed
Nov 12, 2019
koetsier
reviewed
Nov 12, 2019
koetsier
reviewed
Nov 12, 2019
koetsier
reviewed
Nov 12, 2019
koetsier
reviewed
Nov 12, 2019
koetsier
reviewed
Nov 12, 2019
koetsier
requested changes
Nov 12, 2019
|
The spacing above criteria seems quite large:
and spacing between the end of criteria and the start of actions seems a bit too small:
|
|
Is there meant to be a border-top on the email subscription section?
|
|
Sidebar layout: There's an additional wrapping
|
Tests fail if it's a <p> tag instead of <div>, view layers remain unchanged when it is either
Updated to match newer choice of assistance pet, avoid travel business question
There's only a single test here anyway, so it doesn't dry out much, and there's an irregular test failure reporting 'No such file or directory @ rb_sysopen - /tmp/downloaded.csv20191111-37-uz5lkw', this is an attempt to resolve any ordering issues
This is a bold title above the link.
We move this CSS out of the .app-c-email-link__link hierarchy as it's no longer a link, and we remove changing the colour of the icon to match the link colour.
Otherwise the blue border sits against the grey border of the 'stay_updated' section.
huwd
force-pushed
the
groupActionsByResults
branch
from
2dc5613
to
b059bf6
Compare
Next to continue
huwd
changed the title
huwd
force-pushed
the
groupActionsByResults
branch
from
f9e8347
to
79da247
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello: https://trello.com/c/uLLaEVPV/186-dont-deploy-update-checker-results-page
PEP restricted PR
🚨 Do not merge until product has approved. 🚨
Included Changes: